Change default fast-check-subsumption
to false
#2303
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2295.
This PR switches the default value for
--fast-check-subsumption
tofalse
(and removes--no-fast-check-subsumption
) to match a similar change in its default inexec_prove
function (#2287 (comment)).After a discussion with @nwatson22, we decided to submit it as a standalone (this) PR for the inconsistency to be fixed sooner, while @nwatson22 is working on a bigger and more general refactoring of the way that the default values are provided and handled: runtimeverification/pyk#885, runtimeverification/kontrol#298.