FST serializer: fixes to intermittent, concurrency failures #1037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dwightguth
approved these changes
Jan 16, 2020
There was a problem hiding this comment.
From what I can see, Java 8 already uses ParallelGC as the default, so that's not a change, but newer versions of Java use the G1 collector by default. Apparently ParallelGC has higher throughput than G1 but at the expense of higher pause times. Given that the Java code in K is not typically interactive, throughput is more important than latency, so this seems like a reasonable alteration to me.
Baltoli
pushed a commit
that referenced
this pull request
Apr 9, 2024
Co-authored-by: devops <[email protected]> Co-authored-by: Tamás Tóth <[email protected]>
Baltoli
pushed a commit
that referenced
this pull request
Apr 9, 2024
Co-authored-by: devops <[email protected]> Co-authored-by: Tamás Tóth <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this PR K Jenkins fails in ~20% of runs. When definition cache will be merged, it is expected to fail more often.
Proof, 15 K builds passed on Jenkins: #1034
References:
RuedigerMoeller/fast-serialization#274