Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: audit: remove ignore of time 0.1 vuln (no longer present) #25

Merged
merged 2 commits into from
May 30, 2024

Conversation

rursprung
Copy link
Owner

this is effectively a git revert 15acb6d (but not done as such to provide a more detailed commit message).
starting with chrono v0.4.30 the dependency to time has been removed, accordingly cargo audit no longer finds any issues here.

rursprung added 2 commits May 30, 2024 16:57
this is effectively a `git revert 15acb6d` (but not done as such to
provide a more detailed commit message).
starting with chrono v0.4.30 the dependency to `time` has been removed,
accordingly `cargo audit` no longer finds any issues here.
this has two reasons:
- the format & audit checks are the same on all platforms, thus running
  it multiple times adds no benefits
- `cargo-audit` seems to be no longer provided on the Mac OS VMs and
  would now have to be manually added (but is still present on Ubuntu &
  Windows).
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@rursprung rursprung merged commit 106f870 into master May 30, 2024
14 checks passed
@rursprung rursprung deleted the remove-cargo-audit-ignore-of-time-in-CI branch May 30, 2024 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant