Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove the InputLength trait #1747

Merged
merged 3 commits into from
May 5, 2024
Merged

remove the InputLength trait #1747

merged 3 commits into from
May 5, 2024

Conversation

Geal
Copy link
Collaborator

@Geal Geal commented May 5, 2024

No description provided.

Copy link

codecov bot commented May 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.22%. Comparing base (d8e67fe) to head (0a14c5a).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1747      +/-   ##
==========================================
- Coverage   62.31%   62.22%   -0.10%     
==========================================
  Files          24       24              
  Lines        2927     2917      -10     
==========================================
- Hits         1824     1815       -9     
+ Misses       1103     1102       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codspeed-hq bot commented May 5, 2024

CodSpeed Performance Report

Merging #1747 will not alter performance

Comparing remove-inputlength (0a14c5a) with main (d8e67fe)

Summary

✅ 23 untouched benchmarks

@@ -208,7 +208,7 @@ where
/// ```
pub fn line_ending<T, E: ParseError<T>>(input: T) -> IResult<T, T, E>
where
T: Input + InputLength,
T: Input + Input,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

redundant bound

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch, thanks

@Geal Geal merged commit 46eaa0a into main May 5, 2024
31 of 32 checks passed
@Geal Geal deleted the remove-inputlength branch May 5, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants