Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Add support for Bitcoin Core v28 #22

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

tnull
Copy link

@tnull tnull commented Aug 30, 2024

Based on #21.

Currently still work in progress (as v28.0rc1 has just been released, so no final binaries are available etc).

@tnull tnull marked this pull request as draft August 30, 2024 10:15
Copy link
Member

@tcharding tcharding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this man. Can you pull the formatting changes out please, I was surprised to see changes to the json/src/v17 files. Also, did you get the contents of rpc-ap.txt from running bitcoin-cli help against a Core v28 instance or did you copy'paste for another existing file? (EDIT: Oh submitpackage only exists in v28 so you must have used bitcoin-cli :)

I merged #22 so you can rebase when you feel like it. Cheers

client/src/client_sync/v28.rs Outdated Show resolved Hide resolved
client/src/client_sync/v28.rs Outdated Show resolved Hide resolved
client/src/client_sync/v28.rs Outdated Show resolved Hide resolved
Add support and testing for Bitcoin Core versions `28.0`
@tnull
Copy link
Author

tnull commented Sep 2, 2024

Thanks for working on this man. Can you pull the formatting changes out please, I was surprised to see changes to the json/src/v17 files.

Ah, now dropped them, didn't realize they slipped in as I didn't expect it either.

Also, did you get the contents of rpc-ap.txt from running bitcoin-cli help against a Core v28 instance or did you copy'paste for another existing file? (EDIT: Oh submitpackage only exists in v28 so you must have used bitcoin-cli :)

Jup, run bitcoin-cli (took me a while to get where rpc-api.txts are coming from though :)

I merged #22 so you can rebase when you feel like it. Cheers

Cool, rebased for now, will resume work ~end of this week.

@tcharding
Copy link
Member

tcharding commented Sep 2, 2024

(took me a while to get where rpc-api.txts are coming from though :)

Ha! So we need a "How to add support for a new version" doc. I'd love a script to check that all the rpc-ap.txt files actually come from bitcoin-cli help > rpc-api.txt for the correct version of Core and are not just copied from another file. Yesterday I was looking at the wrong buffer in my editor and thought I'd made a mistake so went back and checked manually. It would be nice to check that the mod.rs rustdoc is using the correct rpc-api.txt content as well, as it is we just have to hope I didn't get mixed up :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants