Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: improve context err #760

Merged
merged 2 commits into from
Oct 21, 2024

Conversation

ChrisCho-H
Copy link
Contributor

919bc4b

  • use ImpossibleSatisfaction when op_count is None instead of MaxOpCountExceeded.

51a50ae

  • unify error message for satisfaction-kind error and scriptPubKey-kind error so that these error can contain max(limit) with what it got(actual).

@ChrisCho-H ChrisCho-H changed the title Feature/improve ctx err feature: improve context err Oct 19, 2024
@ChrisCho-H ChrisCho-H force-pushed the feature/improve-ctx-err branch 2 times, most recently from 81b9932 to c197c0b Compare October 19, 2024 12:08
@apoelstra
Copy link
Member

In c197c0b:

Can you change "{} items more than limit {}" to "{} items (limit: {})` or something? As written it sounds like we're exceeding the limit by the given amount, rather than exceeding the limit with the given amount.

Otherwise this looks great. Thanks for cleaning these up!

@ChrisCho-H
Copy link
Contributor Author

faf16fd

  • changed the err message which might be misleading!

Copy link
Member

@apoelstra apoelstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK faf16fd; successfully ran local tests

@apoelstra apoelstra merged commit aa3691d into rust-bitcoin:master Oct 21, 2024
29 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants