Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Add a rand-std feature" #158

Merged
merged 1 commit into from
Sep 9, 2019
Merged

Revert "Add a rand-std feature" #158

merged 1 commit into from
Sep 9, 2019

Conversation

apoelstra
Copy link
Member

@apoelstra apoelstra commented Sep 9, 2019 •
edited
Loading

Reverts #153

This was included in 0.15.4 (which was an emergency release due to cc breakage) but shouldn't be included until 0.16.0.

Fixes #157

@elichai
Copy link
Member

elichai commented Sep 9, 2019

Opss sorry.
So you want to revert this and re-include for 0.16.0?
Or you want to think of a different fix for #150?

jonasnick
jonasnick approved these changes Sep 9, 2019
View reviewed changes
Copy link
Collaborator

@jonasnick jonasnick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK bbab1c2 can confirm that rust-bitcoin tests compile again with this PR.

@apoelstra
Copy link
Member Author

@elichai as per our in-person discussion, I think we should re-introduce it for 0.16.0

@apoelstra apoelstra merged commit 0e5e314 into master Sep 9, 2019
@apoelstra apoelstra deleted the revert-153-2019-08-rand-std-feature branch September 9, 2019 10:26
@elichai elichai mentioned this pull request Oct 28, 2019
Merged
@elichai elichai mentioned this pull request Jan 9, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonasnick jonasnick jonasnick approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🐛 "generate_keypair is not found" in version 0.15.4
3 participants
@apoelstra @elichai @jonasnick