Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade regex dependency #285

Closed
wants to merge 1 commit into from
Closed

Conversation

SpamapS
Copy link

@SpamapS SpamapS commented Nov 12, 2023

There have been a number of performance enhancements which make having
a newer regex desirable. However the most important change was dropping
thread_local in 1.4.4. Thread_local had some security vulnerabilities,
making it trigger lots of dependabot alerts when it lands in Cargo.lock
files.

There have been a number of performance enhancements which make having
a newer regex desirable. However the most important change was dropping
thread_local in 1.4.4. Thread_local had some security vulnerabilities,
making it trigger lots of dependabot alerts when it lands in Cargo.lock
files.
@matthiasbeyer
Copy link
Member

As far as I can see, regex is not exported from our public interface, but only used in https://github.com/rust-cli/env_logger/blob/main/src/filter/regex.rs 👀

I'll approve CI, but leave the final decision to @epage here.

@epage
Copy link
Contributor

epage commented Nov 13, 2023

I intentionally do not bump library version requirements unless we specifically need something from it. This avoids churn for end users and lets them workaround problems on their side by picking the version they want. By default, cargo will pick the latest version for them and they are free to update their lockfile (our lockfile has no effect on them).

@epage epage closed this Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants