Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove traits with unconstrained Time associated types. #324

Merged
merged 1 commit into from
Feb 9, 2022

Commits on Nov 3, 2021

  1. Remove traits with unconstrained Time associated types.

    As discussed in rust-embedded#201 and
    rust-embedded#177 (comment) ,
    the traits that have an unconstrained `type Time` associated type end up
    not being usable for HAL-independent drivers in practice, since there is too
    much variation across HALs of what the actual Time type is.
    
    These should be bound to something, probably a `Duration` trait, so that
    drivers can actually create and use them. Alternatively embedded-hal could have
    actual `struct Duration` and so.
    
    Either way, it's unclear what the final solution would look like. We shouldn't leave
    these traits in the 1.0 release, since fixing them later will be a breaking change.
    We should temporarily remove them, and add them back once we have figured this out
    which won't be a breaking change.
    Dirbaio committed Nov 3, 2021
    Configuration menu
    Copy the full SHA
    513807e View commit details
    Browse the repository at this point in the history