Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update minimum embedded-io version for embedded-io-async #617

Merged
merged 1 commit into from
Jul 16, 2024

Conversation

jamesmunns
Copy link
Member

The 0.6.0 version of embedded-io does not have SliceWriteError in the public API, leading to this error if the 0.6.0 version is selected:

error[E0432]: unresolved import `embedded_io::SliceWriteError`
 --> /Users/james/.cargo/registry/src/index.crates.io-6f17d22bba15001f/embedded-io-async-0.6.1/src/impls/slice_mut.rs:2:5
  |
2 | use embedded_io::SliceWriteError;
  |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ no `SliceWriteError` in the root

For more information about this error, try `rustc --explain E0432`.
error: could not compile `embedded-io-async` (lib) due to 1 previous error
warning: build failed, waiting for other jobs to finish...

This means that embedded-io-async requires at least embedded-io 0.6.

The 0.6.0 version of `embedded-io` does not have `SliceWriteError` in the public API, leading to this error if the 0.6.0 version is selected:

```
error[E0432]: unresolved import `embedded_io::SliceWriteError`
 --> /Users/james/.cargo/registry/src/index.crates.io-6f17d22bba15001f/embedded-io-async-0.6.1/src/impls/slice_mut.rs:2:5
  |
2 | use embedded_io::SliceWriteError;
  |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ no `SliceWriteError` in the root

For more information about this error, try `rustc --explain E0432`.
error: could not compile `embedded-io-async` (lib) due to 1 previous error
warning: build failed, waiting for other jobs to finish...
```

This means that embedded-io-async requires *at least* embedded-io 0.6.
@jamesmunns jamesmunns requested a review from a team as a code owner July 13, 2024 17:21
@Dirbaio Dirbaio added this pull request to the merge queue Jul 16, 2024
Merged via the queue into rust-embedded:master with commit d31dfde Jul 16, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants