Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

registers_with_uniq_names #216

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

astro
Copy link
Contributor

@astro astro commented May 11, 2018

Here is a proposal to solve one more issue I found in the LPC13xx .svd file: registers with duplicate names.

This PR does not simply drop the duplicate identifiers but tries to rename them by appending 2, or 3, and so on.

@astro
Copy link
Contributor Author

astro commented May 11, 2018

I had to add more remedies to get valid code generated from this .svd file. Suggestions for improving this PR are welcome!

@Emilgardis
Copy link
Member

Adding _x to a register seems to me to be a sub-optimal solution. What registers have duplicate names? Could this be solved with <alternateGroup> (which has not been implemented as of v0.13.1)

@mathk
Copy link

mathk commented Feb 22, 2019

Ping from triage: @astro are you still looking for improvement idea ?

@mathk mathk added the S-waiting-on-author Status: The marked PR is awaiting some action (such as code changes) from the PR author. label Feb 22, 2019
@astro
Copy link
Contributor Author

astro commented Feb 27, 2019

@mathk That would be helpful.

@burrbull
Copy link
Member

If this is still actual, please rebase.

@burrbull burrbull marked this pull request as draft April 17, 2021 04:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-author Status: The marked PR is awaiting some action (such as code changes) from the PR author.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants