feat: Remove largest duplicate substr of reg name #268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shaydonb
force-pushed
the
feat/remove-duplicates
branch
from
603e2fb to
1f9bdf8
Compare
Problem: Sometimes register names contain duplicate strings that unnecessarily lengthen them. Solution: Remove the largest duplicated substring, with a specified delimiter to avoid removing mere duplicated characters. Testing: Unit-level test of helper function, integration level test with SVD file in and expected out. Issues: Closes rust-embedded#267.
shaydonb
force-pushed
the
feat/remove-duplicates
branch
from
1f9bdf8 to
0e3ac47
Compare
burrbull
reviewed
Jan 10, 2025
Comment on lines
+481
to
+483
| // Define a regex to match duplicated groups of underscore-separated words | ||
| // As it turns out, this is not viable since backreferences are not supported by Regex in Rust | ||
| // let re = Regex::new(r"(?i)(\b(?:\w+_)+\w+)_\1").unwrap(); |
There was a problem hiding this comment.
Sounds not very good.
As for me this case looks too specific. What vendor do this?
Some time ago I was thinking about some more common way like supporting regex based replace. Something like:
PER:
_replace:
"REGSPEC*":
name: # what string entry to process
"namematch": "to" # first replacement
"namematch2": "to2" # second replacement
description:
"descmatch": "to"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: Sometimes register names contain duplicate strings that unnecessarily lengthen them.
Solution: Remove the largest duplicated substring, with a specified delimiter to avoid removing mere duplicated characters.
Testing: Unit-level test of helper function, integration level test with SVD file in and expected out.
Issues: Closes #267.