Skip to content

Commit

Permalink
Auto merge of rust-lang#134608 - DianQK:disable-93775, r=jieyouxu
Browse files Browse the repository at this point in the history
Add `ignore-rustc-debug-assertions` to `tests/ui/associated-consts/issue-93775.rs`

Closes rust-lang#132111. Closes rust-lang#133432.

I think this test case is flaky because the recursive calls happen to hit the upper limit of the call stack.

IMO, this may not be an issue, as it's reasonable for overly complex code to require additional build configurations (such as increasing the call stack size).

After set `rust.debug-assertions` is true, the test case requires a larger call stack, so disable it on `rust.debug-assertions=true`.

r? jieyouxu

try-job: x86_64-msvc
try-job: i686-msvc
  • Loading branch information
bors committed Dec 23, 2024
2 parents 0eca4dd + 4dca485 commit 66bb586
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions tests/ui/associated-consts/issue-93775.rs
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
//@ ignore-windows-msvc
// FIXME(#132111, #133432): this test is flaky on windows msvc, it sometimes fail but it sometimes
// passes.
//@ ignore-rustc-debug-assertions
// Similar to stress testing, the test case requires a larger call stack,
// so we ignore rustc's debug assertions.

//@ build-pass
// ignore-tidy-linelength
Expand Down

0 comments on commit 66bb586

Please sign in to comment.