Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(package): Recognize and normalize cargo.toml #12399

Merged
merged 6 commits into from
Jul 29, 2023
Merged

Commits on Jul 24, 2023

  1. Configuration menu
    Copy the full SHA
    5dd39df View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    bbb6aff View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    f4c97b2 View commit details
    Browse the repository at this point in the history
  4. fix(package): Warn when manifest is not more generally found

    Being a bit cautious about not turning this into an error since this is
    most likely because of case insensitive filesystems.
    epage committed Jul 24, 2023
    Configuration menu
    Copy the full SHA
    3166e5f View commit details
    Browse the repository at this point in the history

Commits on Jul 26, 2023

  1. Configuration menu
    Copy the full SHA
    9b14e39 View commit details
    Browse the repository at this point in the history
  2. fix(package): Avoid multiple package list entries

    To keep things simple, especially in getting a `Hash` implementation
    correct, I'm leveraging `unicase` for case-insensitive
    comparisons which is an existing dependency and I've been using for
    years on other projects.
    
    This also opens the door for us to add cross-platform compatibility
    hazard warnings about multiple paths that would write to the same
    location on a case insensitive file system.  I held off on that because
    I assume we would want rust-lang#12235 first.
    
    This does mean we can't test the "no manifest" case anymore because the
    one case (no pun intended) I knew of for hitting it is now gone.
    epage committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    cc6b6c9 View commit details
    Browse the repository at this point in the history