Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Add test codebase for shell completions #14681

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

shannmu
Copy link
Contributor

@shannmu shannmu commented Oct 13, 2024

What does this PR try to resolve?

Tracking issue #14520

  • Refactor candidates generators to make them testable
  • Add a test codebase and template project used for building test cases
  • Add test code for get_registry_candidates, get_example_candidates, get_test_candidates, get_bench_candidates, get_bin_candidates

…pletions`

Passing `cwd` to custom completion functions makes that we could generate completions in the template project.
- Add an empty template project, which is used for building test cases
- Add a format function used for completions result
- Sort the order of example candidates by the way
@rustbot
Copy link
Collaborator

rustbot commented Oct 13, 2024

r? @epage

rustbot has assigned @epage.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-cli Area: Command-line interface, option parsing, etc. Command-add Command-uninstall Command-update S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-cli Area: Command-line interface, option parsing, etc. Command-add Command-uninstall Command-update S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants