-
Notifications
You must be signed in to change notification settings - Fork 459
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support new NTO QNX targets #1312
base: main
Are you sure you want to change the base?
Conversation
Thanks for the PR! The I think this is the first time that a Rust target is added since #1225, I'd like to know what you think we can do better (apart from improving the error message) to make such work smoother in the future? |
30ba3ec
to
66cfc7d
Compare
Thanks for the feedback, I've reverted the changes of Something that would have helped me (and I think @thejpster as well) is:
|
Thanks for the feedback! I've opened #1313 to improve the error message, would like your input there on how the dev guide could be improved too! |
66cfc7d
to
eaff721
Compare
The PR now only adds the new target_env definition. The error message is now improved with #1313. |
You can modify and run It will generate this src/target/generated |
eaff721
to
3718de7
Compare
This change:
This depends on rust-lang/rust/pull/133631
CC: @jonathanpallant @japaric @gh-tr @AkhilTThomas