Do not allocate capacity in ready_chunks #2657
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm... Depending on the size of the item, reallocation may occur with each push, but 1024 bytes on the stack is relatively large, so it probably seems fine? |
Snippet you pointed at is min non-zero capacity. The following line is: where old Or I didn't understand your comment. |
`read_chunks` practically often returns items when not all capacity filled. So always allocating full capacity results in excessive allocation. This is especially an issue when `capacity` parameter passed is large (to be able to handle streams efficiently under high load).
stepancheg
force-pushed
the
ready-chunks-cap
branch
from
b88c894 to
d8b355a
Compare
stepancheg
added a commit
to stepancheg/futures-rs
that referenced
this pull request
Oct 30, 2022
Reserving `ready_chunks` limit every time may be too expensive when the limit is high but only a few number of messages available. Now rely on `Stream::size_hint` to reserve the capacity. If underlying stream implements `size_hint`, this will work great. Otherwise `ready_chunk` will be somewhat less efficient. This is better alternative to rust-lang#2657
stepancheg
added a commit
to stepancheg/futures-rs
that referenced
this pull request
Oct 30, 2022
Reserving `ready_chunks` limit every time may be too expensive when the limit is high but only a few number of messages available. Now rely on `Stream::size_hint` to reserve the capacity. If underlying stream implements `size_hint`, this will work great. Otherwise `ready_chunk` will be somewhat less efficient. This is better alternative to rust-lang#2657
|
Closing in favor of #2661. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
read_chunkspractically often returns items when not all capacity filled. So always allocating full capacity results in excessive allocation.This is especially an issue when
capacityparameter passed is large (to be able to handle streams efficiently under high load).