Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sidebar opening/closing sometimes doesn't open/close it #2520

Closed
WaffleLapkin opened this issue Jan 8, 2025 · 2 comments · Fixed by #2532
Closed

Sidebar opening/closing sometimes doesn't open/close it #2520

WaffleLapkin opened this issue Jan 8, 2025 · 2 comments · Fixed by #2532
Labels
C-bug Category: A bug, incorrect or unintended behavior

Comments

@WaffleLapkin
Copy link
Member

WaffleLapkin commented Jan 8, 2025 •
edited
Loading

Problem

Sometimes the button to open sidebar seems to do nothing.

Steps

  1. Go to https://doc.rust-lang.org/nightly/reference/type-coercions.html
  2. open dev tools
  3. click on the hamburger in the left top corner until one of your clicks doesn't make the sidebar open/close
  4. observe the fact that <body> has incorrect class (sidebar-visible is the sidebar is hidden and vice-versa)
  5. click on the hamburger again and observe that the classes are still incorrect

Possible Solution(s)

No response

Notes

The bug is random, so sometimes you need to click a lot before it happens. And sometimes it happens once in about 4 clicks. 🤷

Also is reproducible in both firefox and chrome.

Version

I can reproduce with mdbook v0.4.43
@WaffleLapkin WaffleLapkin added the C-bug Category: A bug, incorrect or unintended behavior label Jan 8, 2025
@ehuss
Copy link
Contributor

ehuss commented Jan 17, 2025

I've not been able to reproduce this. Does it happen in safe mode, or a fresh profile?
Can you share a screen recording?

@WaffleLapkin
Copy link
Member Author

Yes, I was able to reproduce this in a empty profile in safe mode.

Screen recording: https://youtu.be/47A2avkPNNs

@notriddle notriddle mentioned this issue Jan 23, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-bug Category: A bug, incorrect or unintended behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Prevent the real sidebar position from becoming unsynced from the JS notriddle/mdBook
2 participants
@ehuss @WaffleLapkin