Prevent the real sidebar position from becoming unsynced from the JS #2532
+4
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This way, whatever behavior the browser might use for checkboxes will apply to the CSS class, localStorage, and the visible state.
notriddle
force-pushed
the
sync-toggle
branch
from
54f674c to
74d48f5
Compare
ehuss
approved these changes
Jan 25, 2025
|
I was able to reproduce it. Maybe it only happens in Firefox? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This way, whatever behavior the browser might use for checkboxes will apply to the CSS class, localStorage, and the visible state.
Fixes #2520