Make Polonius report any found errors by default #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's a bit confusing that running Polonius on some Rust code that you know has a borrow error doesn't seem to actually do anything - it gives the impression that no analysis is performed by default. Of course, analysis *is* performed by default, but errors aren't reported unless you opt in (which begs the question of what exactly the tool is meant to be doing when you run it!) This changes the behaviour to print error tuples by default if any are found, for a better experience. The old behaviour can be re-enabled by using `--no-show-tuples` to suppress tuple output even if errors are present.
ivanbakel
force-pushed
the
feature/errors-by-default
branch
from
099d033
to
5c995c7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's a bit confusing that running Polonius on some Rust code that you know has a borrow error doesn't seem to actually do anything - it gives the impression that no analysis is performed by default.
This changes the behaviour to print error tuples by default if any are found, for a better experience. The old behaviour can be re-enabled by using
--no-show-tuplesto suppress tuple output even if errors are present.