RFC: Cargo feature deprecation #3486
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgross35
force-pushed
the
feature-deprecation
branch
from
ec49bf1
to
0c803c3
Compare
tgross35
force-pushed
the
feature-deprecation
branch
from
0c803c3
to
6c3d1f4
Compare
compiler-errors
added
the
T-cargo
The hope with these changes is to clarify what is there and not to change what the author intended.
epage
reviewed
Sep 10, 2023
Comment on lines
+113
to
+115
| [rationale-and-alternatives]: #rationale-and-alternatives | ||
|
|
||
| WIP |
There was a problem hiding this comment.
Don't forget to close this out
epage
reviewed
Sep 10, 2023
Comment on lines
+119
to
+121
| [prior-art]: #prior-art | ||
|
|
||
| WIP |
There was a problem hiding this comment.
Don't forget to close this out
epage
reviewed
Sep 10, 2023
Comment on lines
+142
to
+144
| - A `rust-version` field that could indicate e.g. `rust-version = "nightly"` or | ||
| `rust-version = "1.65"` to specify a MSRV for that feature. See: | ||
| <https://github.com/rust-lang/rfcs/pull/3416#discussion_r1174478461> |
There was a problem hiding this comment.
How is this related to deprecation?
epage
reviewed
Sep 10, 2023
Comment on lines
+138
to
+141
| - A `stable` field can be set false to indicate API-unstable or nightly-only | ||
| features (something such as `stable = 3.2` could be used to indicate when a | ||
| feature was stabilized). See also: | ||
| <https://github.com/rust-lang/cargo/issues/10882> |
There was a problem hiding this comment.
How is this connected to this RFC?
fbstj
reviewed
Sep 10, 2023
| ```toml | ||
| [features] | ||
| foo = { enables = [], deprecated = true } | ||
| foo = { enables = [], deprecated = "this works as a note" } |
There was a problem hiding this comment.
theres two foo features, is that intentional?
fbstj
reviewed
Sep 10, 2023
epage
added
the
S-waiting-on-author
Co-authored-by: Joe ST <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rendered
RFC for
feature-deprecationRFC goals: add a way to deprecate Cargo features
This was split from #3416
This would resolve rust-lang/cargo#7130