-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add trait_impl_reduntant_assoc_item diagnostic #15990
feat: add trait_impl_reduntant_assoc_item diagnostic #15990
Conversation
crates/ide-diagnostics/src/handlers/trait_impl_reduntant_assoc_item.rs
Outdated
Show resolved
Hide resolved
crates/ide-diagnostics/src/handlers/trait_impl_reduntant_assoc_item.rs
Outdated
Show resolved
Hide resolved
d18ead5
to
647eb2b
Compare
@rustbot ready |
crates/ide-diagnostics/src/handlers/trait_impl_redundant_assoc_item.rs
Outdated
Show resolved
Hide resolved
Small nit but otherwise lgtm. We should definitely look into adding some more utility functions for creating better diagnostic text ranges for things (currently most assists still create the ranges in some random ways). @bors delegate+ |
✌️ @Young-Flash, you can now approve this pull request! If @Veykril told you to " |
731a3df
to
fbe494a
Compare
☀️ Test successful - checks-actions |
Hi! This feature introduced a bug when unwrapping this rust-analyzer/crates/ide-diagnostics/src/handlers/trait_impl_redundant_assoc_item.rs Line 47 in 932d85b
The function returns rust-analyzer/crates/span/src/lib.rs Lines 253 to 259 in 932d85b
Maybe changing it to something like rust-analyzer/crates/ide-diagnostics/src/handlers/trait_impl_missing_assoc_item.rs Lines 23 to 31 in f532576
|
…eykril feat: add quickfix for redundant_assoc_item diagnostic Happy New Year 😊 follow up #15990, now it's time to close #15958, closes #16269 ![demo](https://github.com/rust-lang/rust-analyzer/assets/71162630/74022c52-1566-49a0-9be8-03b82f3e730f) EDIT: add a demo.git would be more illustrated when making release change log.
part of #15958, will try to add quickfix for the diagnostic if this PR is ok with you guys