Introduce $CONFIG_DIR/rust-analyzer/rust-analyzer.toml
#18070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
alibektas
force-pushed
the
user_rtml_on_start
branch
from
cf52190
to
9f70fb3
Compare
alibektas
force-pushed
the
user_rtml_on_start
branch
from
9f70fb3
to
6b70b32
Compare
alibektas
force-pushed
the
user_rtml_on_start
branch
from
6b70b32
to
cadeaec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the use of
rust-analyzer.tomlunder user config directory possible. The reason why this is a draft is that some of the tests are flaky due to the way we set user config directory in our tests. Basically, to redirect server to a different path than the usual user config dir (~/.config/rust-analyzer/rust-analyzer.toml) we set an envvar called__TEST_RA_USER_CONFIG_DIR. During parallel executions this value gets rewritten although we use a lock to prevent this.In short, I am looking for some help on how to fix this.
And this PR is based on another that has currently not been merged ( #18057 ) so I will kindly ask you to focus on the most recent commit (
9f70fb3d) only.