Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

internal: Build source map for hir_def::TypeRefs #18074

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

internal: Build source map for hir_def::TypeRefs #18074

wants to merge 2 commits into from
+1,773 −825

Commits on Oct 13, 2024

  1. Build source map for hir_def::TypeRefs 

    So that given a `TypeRef` we will be able to trace it back to source code.

This is necessary to be able to provide diagnostics for lowering to chalk tys, since the input to that is `TypeRef`.

This means that `TypeRef`s now have an identity, which means storing them in arena and not interning them, which is an unfortunate (but necessary) loss but also a pretty massive change. Luckily, because of the separation layer we have for IDE and HIR, this change never crosses the IDE boundary.
    @ChayimFriedman2
    ChayimFriedman2 committed Oct 13, 2024
    Configuration menu
    Copy the full SHA
    1d4bbf6 View commit details
    Browse the repository at this point in the history

  2. Fix memory usage calculation's queries list

    @ChayimFriedman2
    ChayimFriedman2 committed Oct 13, 2024
    Configuration menu
    Copy the full SHA
    9a2a0a2 View commit details
    Browse the repository at this point in the history