Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix non-cargo flychecks immediately clearing received diagnostics #18848

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

Veykril
Copy link
Member

@Veykril Veykril commented Jan 6, 2025

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 6, 2025
@Veykril Veykril enabled auto-merge January 6, 2025 12:45
@Veykril Veykril added this pull request to the merge queue Jan 6, 2025
Merged via the queue into rust-lang:master with commit 3f2bbe9 Jan 6, 2025
9 checks passed
@Veykril Veykril deleted the push-kyyoskmvnutp branch January 6, 2025 13:14
@@ -419,6 +420,7 @@ impl FlycheckActor {
self.command_receiver.take();
self.report_progress(Progress::DidCancel);
self.diagnostics_cleared_for.clear();
self.diagnostics_received = false;
Copy link
Member Author

@Veykril Veykril Jan 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The bug for things not clearing is here, this line and the above should not be gated by the surrounding if let, the handle is taken on a completed check so we don't reset in thst case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Diagnostics are not displayed anymore in Cargoless setup
2 participants