fix: clear diagnostics on cancel unconditionally #18858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
ChayimFriedman2
approved these changes
Jan 6, 2025
|
The bug will only get triggered when diagnostics are not cancelled AFAIK. Anyway I tested this and this works. |
|
As a general policy, is there a need for a test so that future regressions of this nature are prevented? (And thank you for the prompt fix!) |
|
@contextref In general we do require tests, but flycheck specifically is a part that is hard to test. |
|
To expand on what Chayim said, we'd need to rewrite flycheck to make it more testable. We probably should, but given the widespread nature of the breakage, that'll need to be a "later" thing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #18854.
This is just an impl of Lukas's comment; I tested this on rust-analyzer, canceled flycheck while it was running, and saw diagnostics get cleared when they previously wouldn't.