Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update doc wildcard_dependencies #13810

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update doc wildcard_dependencies #13810

wants to merge 1 commit into from

Conversation

alex-semenyuk
Copy link
Member

Currently https://rust-lang.github.io/rust-clippy/master/index.html#wildcard_dependencies doc doesn't contain explanation how it should be so added more details

changelog: none

@rustbot
Copy link
Collaborator

rustbot commented Dec 11, 2024

r? @Jarcho

rustbot has assigned @Jarcho.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Dec 11, 2024
@alex-semenyuk alex-semenyuk force-pushed the fix_doc_wildcard_dependency branch from 03491c8 to ff27097 Compare December 11, 2024 08:07
Jarcho
Jarcho requested changes Dec 14, 2024
View reviewed changes
Copy link
Contributor

@Jarcho Jarcho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching the missing example.

clippy_lints/src/cargo/mod.rs Outdated Show resolved Hide resolved
clippy_lints/src/cargo/mod.rs Outdated Show resolved Hide resolved
@alex-semenyuk alex-semenyuk force-pushed the fix_doc_wildcard_dependency branch from ff27097 to 7ddfed2 Compare December 14, 2024 12:01
@alex-semenyuk alex-semenyuk requested a review from Jarcho December 14, 2024 12:11
@alex-semenyuk alex-semenyuk force-pushed the fix_doc_wildcard_dependency branch 2 times, most recently from 02f8048 to 1d9baff Compare December 20, 2024 19:54
@alex-semenyuk alex-semenyuk force-pushed the fix_doc_wildcard_dependency branch from 1d9baff to cf331d2 Compare December 20, 2024 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jarcho Jarcho Awaiting requested review from Jarcho

Requested changes must be addressed to merge this pull request.

Assignees

@Jarcho Jarcho

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alex-semenyuk @rustbot @Jarcho