Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if deref target implements is_empty for len_zero lint #13871

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

samueltardieu
Copy link
Contributor

In this case, the lint can be triggered as well as is_empty() will be found on the target type.
One such case was found in Clippy sources (first commit)

changelog: [len_zero]: trigger if deref target implements is_empty()

Close #13861

In this case, the lint can be triggered as well as `is_empty()` will be
found on the target type.
@rustbot
Copy link
Collaborator

rustbot commented Dec 23, 2024

r? @y21

rustbot has assigned @y21.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

comparison_to_empty not triggered if comparing Cow<'a, str> to empty string slice
3 participants