Check if deref target implements is_empty for len_zero lint
#13871
+95
−32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In this case, the lint can be triggered as well as `is_empty()` will be found on the target type.
rustbot
added
the
S-waiting-on-review
|
Timo has a lot of work, I'll reassign to myself the ones with no review yet. r? blyxyas |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this case, the lint can be triggered as well as
is_empty()will be found on the target type.One such case was found in Clippy sources (first commit)
changelog: [
len_zero]: trigger if deref target implementsis_empty()Close #13861