Update linux_musl base to dynamically link the crt by default #133386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
However, don't change the behavior of any existing targets at this time. For targets that used the old default, explicitly set `crt_static_default = true`. This makes it easier for new targets to use the correct defaults while leaving the changing of individual targets to future PRs. Related to rust-lang/compiler-team#422
rustbot
added
S-waiting-on-review
|
These commits modify compiler targets. |
jieyouxu
reviewed
Nov 23, 2024
Comment on lines
-11
to
-13
| // These targets statically link libc by default | ||
| base.crt_static_default = true; | ||
|
|
There was a problem hiding this comment.
Question: do we have any way to test (or rather, track) the "finalized" crt static default for each target (as in, after the base and overrides are merged together to produce the final value for a given target)? So that if anyone does modify the default and cause the "finalized" value to change, we do so intentionally with something like a test rebless or test modification?
I looked at --print=all-target-specs-json locally, but AFAICT that omits this field if it's not overriden or something...
There was a problem hiding this comment.
Yeah, I added a run-make test that captures the current state.
|
r? @jieyouxu |
jieyouxu
added
S-waiting-on-author
|
This PR modifies cc @jieyouxu |
This comment has been minimized.
This comment has been minimized.
wesleywiser
force-pushed
the
update_musl_base_crt_default
branch
from
263e6e1 to
3f3ee2d
Compare
tranquillity-codes
added
S-waiting-on-review
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 14, 2024
…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#133221 (Add external macros specific diagnostics for check-cfg) - rust-lang#133386 (Update linux_musl base to dynamically link the crt by default) - rust-lang#134191 (Make some types and methods related to Polonius + Miri public) - rust-lang#134227 (Update wasi-sdk used to build WASI targets) - rust-lang#134279 ((Re-)return adjustment target if adjust kind is never-to-any) - rust-lang#134295 (Encode coroutine-closures in SMIR) r? `@ghost` `@rustbot` modify labels: rollup
bjorn3
reviewed
Dec 14, 2024
| // If the value is `null`, then the default to dynamically link from | ||
| // musl_base was not overriden. | ||
| if default.is_null() { | ||
| continue; |
There was a problem hiding this comment.
Maybe also check that LEGACY_STATIC_LINKING_TARGETS does not contain the target?
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 14, 2024
…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#133221 (Add external macros specific diagnostics for check-cfg) - rust-lang#133386 (Update linux_musl base to dynamically link the crt by default) - rust-lang#134191 (Make some types and methods related to Polonius + Miri public) - rust-lang#134227 (Update wasi-sdk used to build WASI targets) - rust-lang#134279 ((Re-)return adjustment target if adjust kind is never-to-any) - rust-lang#134295 (Encode coroutine-closures in SMIR) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 14, 2024
Rollup merge of rust-lang#133386 - wesleywiser:update_musl_base_crt_default, r=jieyouxu Update linux_musl base to dynamically link the crt by default However, don't change the behavior of any existing targets at this time. For targets that used the old default, explicitly set `crt_static_default = true`. This makes it easier for new targets to use the correct defaults while leaving the changing of individual targets to future PRs. Related to rust-lang/compiler-team#422
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
However, don't change the behavior of any existing targets at this time. For targets that used the old default, explicitly set
crt_static_default = true.This makes it easier for new targets to use the correct defaults while leaving the changing of individual targets to future PRs.
Related to rust-lang/compiler-team#422