Correctly note item kind in NonConstFunctionCall error message
#134701
+107
−105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
A-run-make
|
Some changes occurred to the CTFE machinery cc @rust-lang/wg-const-eval This PR modifies cc @jieyouxu |
compiler-errors
force-pushed
the
non-const-def-descr
branch
from
d566ebf to
92f93f6
Compare
|
make sense to me, r=me if you want (unless you want to wait for fmease of course) |
fmease
approved these changes
Dec 23, 2024
|
@bors r=Urgau,fmease rollup |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 24, 2024
Rollup of 5 pull requests Successful merges: - rust-lang#134638 (Fix effect predicates from item bounds in old solver) - rust-lang#134662 (Fix safety docs for `dyn Any + Send {+ Sync}`) - rust-lang#134689 (core: fix const ptr::swap_nonoverlapping when there are pointers at odd offsets) - rust-lang#134699 (Belay new reviews for workingjubilee) - rust-lang#134701 (Correctly note item kind in `NonConstFunctionCall` error message) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 24, 2024
Rollup merge of rust-lang#134701 - compiler-errors:non-const-def-descr, r=Urgau,fmease Correctly note item kind in `NonConstFunctionCall` error message Don't just call everything a "`fn`". This is more consistent with the error message we give for conditionally-const items, which do note the item's def kind. r? fmease, this is a prerequisite for making those `~const PartialEq` error messages better. Re-roll if you're busy or don't want to review this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't just call everything a "
fn". This is more consistent with the error message we give for conditionally-const items, which do note the item's def kind.r? fmease, this is a prerequisite for making those
~const PartialEqerror messages better. Re-roll if you're busy or don't want to review this.