Add more begin_panic normalizations to panic backtrace tests
#134781
Merged
+12
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @SparrowLii rustbot has assigned @SparrowLii. Use |
rustbot
added
S-waiting-on-review
Zalathar
added
the
A-testsuite
SparrowLii
reviewed
Dec 26, 2024
|
cc @Mark-Simulacrum @jieyouxu since this related with #133997 |
|
It seems reasonable if only to suppress the local failures (but which are not super important for the tests themselves). I don't know the precise reason for the variations, but one possible cause is that the share generics could possibly induce platform-specific behavior in what gets shared and what doesn't (leading to backtrace differences). |
|
I was able to isolate the difference to I don't know precisely why that triggers it, or why it only appears to affect macOS, but backtraces are subject to so much platform-specific behaviour that I don't feel much need to dig further than that. |
|
Yeah, I think that's very reasonable. |
SparrowLii
approved these changes
Dec 26, 2024
|
@bors r=SparrowLii,jieyouxu rollup |
bors
added
S-waiting-on-bors
jieyouxu
added a commit
to jieyouxu/rust
that referenced
this pull request
Dec 26, 2024
…ieyouxu Add more `begin_panic` normalizations to panic backtrace tests Since rust-lang#123244, these tests have started failing locally on some systems (rust-lang#133997) due to minor variations in how `begin_panic` is printed in the backtrace. The variation appears to occur on macOS when `rust.debuginfo-level = "line-tables-only"` is set, which is the default in `config.compiler.toml`. It does not occur when the debuginfo level is set to 1. The variation doesn't seem relevant to these tests, so this PR simply adds another custom normalization rule to account for the variation. --- Will conflict with rust-lang#134759.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 26, 2024
Rollup of 4 pull requests Successful merges: - rust-lang#134664 (Account for removal of multiline span in suggestion) - rust-lang#134774 (fix default-backtrace-ice test) - rust-lang#134781 (Add more `begin_panic` normalizations to panic backtrace tests) - rust-lang#134784 (Miri subtree update) r? `@ghost` `@rustbot` modify labels: rollup
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 26, 2024
…llaumeGomez Rollup of 4 pull requests Successful merges: - rust-lang#134656 (Migrate `incr-add-rust-src-component` to rmake) - rust-lang#134664 (Account for removal of multiline span in suggestion) - rust-lang#134772 (Improve/cleanup rustdoc code) - rust-lang#134781 (Add more `begin_panic` normalizations to panic backtrace tests) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 26, 2024
Rollup merge of rust-lang#134781 - Zalathar:backtrace, r=SparrowLii,jieyouxu Add more `begin_panic` normalizations to panic backtrace tests Since rust-lang#123244, these tests have started failing locally on some systems (rust-lang#133997) due to minor variations in how `begin_panic` is printed in the backtrace. The variation appears to occur on macOS when `rust.debuginfo-level = "line-tables-only"` is set, which is the default in `config.compiler.toml`. It does not occur when the debuginfo level is set to 1. The variation doesn't seem relevant to these tests, so this PR simply adds another custom normalization rule to account for the variation. --- Will conflict with rust-lang#134759.
This was referenced Dec 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since #123244, these tests have started failing locally on some systems (#133997) due to minor variations in how
begin_panicis printed in the backtrace.The variation appears to occur on macOS when
rust.debuginfo-level = "line-tables-only"is set, which is the default inconfig.compiler.toml. It does not occur when the debuginfo level is set to 1.The variation doesn't seem relevant to these tests, so this PR simply adds another custom normalization rule to account for the variation.
Will conflict with #134759.