Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Attempting to handle case insensitive case. #64699

Closed
wants to merge 5 commits into from
Closed

[WIP] Attempting to handle case insensitive case. #64699

wants to merge 5 commits into from

Commits on Sep 26, 2019

  1. Configuration menu
    Copy the full SHA
    cf134d3 View commit details
    Browse the repository at this point in the history

Commits on Sep 27, 2019

  1. Configuration menu
    Copy the full SHA
    64ef0f1 View commit details
    Browse the repository at this point in the history
  2. Auto merge of #64824 - Mark-Simulacrum:no-stable-hasher-result-everyw…

    …here, r=<try>
    
    No StableHasherResult everywhere
    
    This removes the generic parameter on `StableHasher`, instead moving it to the call to `finish`. This has the side-effect of making all `HashStable` impls nicer, since we no longer need the verbose `<W: StableHasherResult>` that previously existed -- often forcing line wrapping.
    
    This is done for two reasons:
     * we should avoid false "generic" dependency on the result of StableHasher
         * we don't need to codegen two/three copies of all the HashStable impls when they're transitively used to produce a fingerprint, u64, or u128. I haven't measured, but this might actually make our artifacts somewhat smaller too.
     * Easier to understand/read/write code -- the result of the stable hasher is irrelevant when writing a hash impl.
    
    cc @eddyb @nikomatsakis I guess? Not sure whose purview this falls under
    
    r? @michaelwoerister due to touching incremental
    bors committed Sep 27, 2019
    Configuration menu
    Copy the full SHA
    66d3e1a View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    3ab835c View commit details
    Browse the repository at this point in the history
  4. paths can overlap for items, even when different items. Thus, caching…

    … needs to take that into account.
    avborhanian committed Sep 27, 2019
    Configuration menu
    Copy the full SHA
    a14aee0 View commit details
    Browse the repository at this point in the history