Switch self profile to use HW counters instead of walltime (attempt 2) #1984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -526,7 +526,7 @@ pub async fn handle_self_profile( | |||
| .benchmark(selector::Selector::One(bench_name.to_string())) | |||
| .profile(selector::Selector::One(profile.parse().unwrap())) | |||
| .scenario(selector::Selector::One(scenario)) | |||
| .metric(selector::Selector::One(Metric::CpuClock)); | |||
| .metric(selector::Selector::One(Metric::InstructionsUser)); | |||
There was a problem hiding this comment.
This will break all historical queries for self-profile data, right? Do we want to perhaps query for both or some other mechanism to not do that?
There was a problem hiding this comment.
An alternative could be to first refactor self profile management (#1896), so that we can e.g. version it, and then have some logic to detect if the archive has the old (walltime) or new (icount) version, and perform the query base on that.
But I'm not sure if people really look at old self-profile results at all, usually we're only interested in them for a brief moment after/before a PR is merged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a second attempt to land #1647, which was later reverted in #1700.
I tried to manually SSH into the collector server and run the whole benchmark suite with
--self-profileusing icounts. It went through. I'd like to try this on the live server to see what happens. If it fails again, we'll know more to see where we should investigate the failure.