Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid showing gray rectangle when width is negative #1987

Merged
merged 1 commit into from
Oct 9, 2024

Conversation

s7tya
Copy link
Contributor

@s7tya s7tya commented Oct 8, 2024

fixes #1983

This happens because the boundary indicating 'out of the specified range' is displayed even when the calculated width is negative.

@s7tya s7tya changed the title do not show gray rect when the width is negative Avoid showing gray rectangle when width is negative Oct 8, 2024
Copy link
Contributor

@Zentrik Zentrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@Kobzol Kobzol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! :)

@Kobzol Kobzol merged commit 6cc3845 into rust-lang:master Oct 9, 2024
11 checks passed
@s7tya s7tya deleted the fix-gray-border branch October 11, 2024 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Odd gray region to right of graph after zooming in
3 participants