Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not install toolchain on rustup show * and rustup --version #2658

Closed
wants to merge 1 commit into from

Conversation

kellda
Copy link
Contributor

@kellda kellda commented Feb 11, 2021

Fixes #1397

@rami3l
Copy link
Member

rami3l commented Jul 10, 2024

@kellda Sorry for being here so late! The rustup show part has been addressed in #3225. I'd like to make you the co-author of the rest.

@kellda
Copy link
Contributor Author

kellda commented Jul 10, 2024

Hi,
No problem about the timing, I didn't try to push this forward either.
I'm not sure to fully understand your message. Do you expect something from me ? Do you need my approval to mark me as co-author somewhere, or should I rebase my PR to fix the rest, or something else ?

@rami3l
Copy link
Member

rami3l commented Jul 10, 2024

@kellda Just your approval to become the co-author would be fine. We'll probably find someone else for the implementation.

@rami3l
Copy link
Member

rami3l commented Jul 15, 2024

Superseded by #3948.

@rami3l rami3l closed this Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rustup show should not force-install the default toolchain if it is not installed.
2 participants