Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(filesource): make some constructs only available via the test feature #3811

Merged
merged 1 commit into from
May 7, 2024

Conversation

rami3l
Copy link
Member

@rami3l rami3l commented May 7, 2024

Cherry-picked from #3803.

This PR has fixed the following warnings in https://github.com/rust-lang/rustup/actions/runs/8978258543/job/24658381207:

 warning: struct `TestStdinLock` is never constructed
    --> src/currentprocess/filesource.rs:47:8
     |
  47 | struct TestStdinLock<'a> {
     |        ^^^^^^^^^^^^^
     |
     = note: `#[warn(dead_code)]` on by default
  
  warning: type alias `TestStdinInner` is never used
    --> src/currentprocess/filesource.rs:68:17
     |
  68 | pub(crate) type TestStdinInner = Arc<Mutex<Cursor<String>>>;
     |                 ^^^^^^^^^^^^^^
  
  warning: struct `TestStdin` is never constructed
    --> src/currentprocess/filesource.rs:70:8
     |
  70 | struct TestStdin(TestStdinInner);
     |        ^^^^^^^^^
  
  warning: struct `TestWriterLock` is never constructed
     --> src/currentprocess/filesource.rs:182:19
      |
  182 | pub(super) struct TestWriterLock<'a> {
      |                   ^^^^^^^^^^^^^^
  
  warning: `rustup` (lib) generated 4 warnings

@rami3l rami3l added this to the 1.28.0 milestone May 7, 2024
@rami3l rami3l requested a review from djc May 7, 2024 03:22
src/currentprocess/filesource.rs Show resolved Hide resolved
@rami3l rami3l requested a review from djc May 7, 2024 10:55
@djc djc added this pull request to the merge queue May 7, 2024
Merged via the queue into master with commit adfcf0f May 7, 2024
22 checks passed
@djc djc deleted the fix/dead-code branch May 7, 2024 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants