refactor(config)!: simplify logic #3986
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rami3l
commented
Aug 9, 2024
rami3l
force-pushed
the
refactor/no-implicit-install-cont
branch
from
f61d03d
to
5e1683d
Compare
rami3l
commented
Aug 10, 2024
djc
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #3985.
I originally wanted to unify
async fn find_or_install_active_toolchain()andfn find_active_toolchain(), but since this essentially involves plugging an async part in the middle of the latter, I finally backed out on this change. Instead, I rewrote the former to look more like the latter, thanks to the fact that I'm now free to change what the former returns.