chore: update static-website action to ubuntu 24 #596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcoIeni
force-pushed
the
chore-update-static-website-action-to-ubuntu-24
branch
7 times, most recently
from
10001fc
to
59de4c9
Compare
|
I also opened #597 for the future |
|
I tested this in rust-lang/thanks@467b526 It's failing because of the newest aws cli. The error message is cryptic but imo the aws cli failed to authenticate. |
MarcoIeni
force-pushed
the
chore-update-static-website-action-to-ubuntu-24
branch
from
59de4c9
to
499db49
Compare
MarcoIeni
force-pushed
the
chore-update-static-website-action-to-ubuntu-24
branch
from
499db49
to
abc0268
Compare
|
it worked after adding the default region! |
|
I'm merging this, we can always revert in case of issues |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
awscli is not present in apt anymore. In the playground we install it with snap, but snap isn't available in docker.
So we need to do this ugly thing to install awscli in ubuntu now.
I want to test this in rust-lang/thanks#72