Skip to content

Commit

Permalink
note why fallible-iterator is a dependency
Browse files Browse the repository at this point in the history
`fallible-iterator` doesn't need to be a dependency, it is pulled in by
`gimli/std` which can't be fixed without rust-lang/cargo#8832.

Signed-off-by: David Wood <[email protected]>
  • Loading branch information
davidtwco committed Dec 7, 2021
1 parent 5f54f22 commit d48ee4a
Show file tree
Hide file tree
Showing 2 changed files with 17 additions and 3 deletions.
6 changes: 5 additions & 1 deletion thorin-bin/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -11,14 +11,18 @@ edition = "2021"
thorin = { path = "../thorin" }

memmap2 = "0.5.0"
object = { version = "0.27.1", features = [ "archive", "read", "write", "compression" ] }
structopt = "0.3.25"
thiserror = "1.0.30"
tracing = "0.1.29"
tracing-subscriber = { version = "0.2.25", features = [ "env-filter" ] }
tracing-tree = "0.1.10"
typed-arena = "2.0.1"

[dependencies.object]
version = "0.27.1"
default-features = false
features = [ "archive", "read", "write", "compression" ]

[[bin]]
name = "thorin"
path = "src/main.rs"
14 changes: 12 additions & 2 deletions thorin/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,17 @@ version = "0.1.0"
edition = "2021"

[dependencies]
gimli = "0.26.1"
indexmap = "1.7.0"
object = { version = "0.27.1", features = [ "archive", "read", "write", "compression" ] }
tracing = "0.1.29"

[dependencies.gimli]
version = "0.26.1"
default-features = false
# `gimli/std` pulls in `fallible-iterator` which we don't use, but can't opt out of, because of
# cargo#8832.
features = [ "read", "write", "std" ]

[dependencies.object]
version = "0.27.1"
default-features = false
features = [ "archive", "read", "write", "compression" ]

0 comments on commit d48ee4a

Please sign in to comment.