allow relative paths for manifest sources #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The main reason for this is so that paths are relative to the crate root and shouldn't exit the crate boundary. That makes it easier when packaging/publishing crates even though relative paths are still allowed iirc. While this may be an annoying limitation for crates in workspaces, those crates are still independent. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am using the cargo-apk crate in a
workspaceenabled project and I had problems withassetsfolder not being a subdirectory ofmanifest.parent, so I implemented a small feature allowing for canonical paths with a fallback to previous handling.