Add bindings for Performance Hint Manager #480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarijnS95
force-pushed
the
performance-hint
branch
from
808ce8a
to
de62105
Compare
MarijnS95
commented
Aug 10, 2024
Comment on lines
+32
to
+44
| /// Retrieve a reference to the performance hint manager. | ||
| /// | ||
| /// Returns [`None`] on failure. | ||
| #[doc(alias = "APerformanceHint_getManager")] | ||
| pub fn new() -> Option<Self> { | ||
| NonNull::new(unsafe { ffi::APerformanceHint_getManager() }).map(|ptr| Self { ptr }) | ||
| } |
There was a problem hiding this comment.
As it turns out there was a hidden static keyword in this C function, this should always return the same singleton for the process:
https://issuetracker.google.com/issues/357214902#comment7
Meaning we can also derive Send/Sync and Copy/Clone since the user could anyway cheaply retrieve the same singleton from any thread.
https://developer.android.com/ndk/reference/group/a-performance-hint Performance Hint Manager allows apps to inform the system about workloads running on threads to more accurately allocate power for them. After the fact, applications should report back how long their operation actually ended up taking. The new work duration API (driven by `AWorkDuration`) also includes GPU timings.
MarijnS95
force-pushed
the
performance-hint
branch
from
de62105
to
c36d9ea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://developer.android.com/ndk/reference/group/a-performance-hint
Performance Hint Manager allows apps to inform the system about workloads running on threads to more accurately allocate power for them. After the fact, applications should report back how long their operation actually ended up taking.
The new work duration API (driven by
AWorkDuration) also includes GPU timings.