ndk: Replace open-coded bool getters with bitflags wrappers
#486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarijnS95
commented
Sep 18, 2024
Comment on lines
-351
to
-354
| #[inline] | ||
| pub fn teriary(self) -> bool { | ||
| self.0 & ffi::AMOTION_EVENT_BUTTON_TERTIARY != 0 | ||
| } |
There was a problem hiding this comment.
Note that this PR will fix the teriary -> TERTIARY typo as pointed out in rust-mobile/android-activity#168 (and a "problem" for android-activity if/when rust-mobile/android-activity#163 is merged), by freshly copying the constants from the header file.
|
We should also do this for |
And "correct" their ABI to match how it is used in the actual NDK getter functions.
MarijnS95
changed the title
bool getters with bitflags wrappersbool getters with bitflags wrappers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And "correct" their ABI to match how it is used in the actual NDK getter functions. Also add missing aliases and upstream documentation where sensible.
CC @rib, I've been thinking about this to make our wrapper types more consistent, but it may be more inconvenient to use now except in the case when checking multiple flags at once...