Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support NHFLAGS [ onlink | pervasive ] #51

Closed
wants to merge 2 commits into from
Closed

support NHFLAGS [ onlink | pervasive ] #51

wants to merge 2 commits into from

Conversation

liuxu623
Copy link

like ip r add default dev eth0 via 169.254.1.1 onlink

Fixes #50

@liuxu623 liuxu623 mentioned this pull request Sep 16, 2023
Open
cathay4t
cathay4t requested changes Sep 19, 2023
View reviewed changes
examples/new_route.rs Outdated Show resolved Hide resolved
examples/new_route.rs Outdated Show resolved Hide resolved
examples/new_route.rs Outdated Show resolved Hide resolved
@cathay4t cathay4t added the Wait_Submitter PR reviewed with change requests label Sep 19, 2023
@liuxu623
Copy link
Author

@cathay4t PTAL

@codecov
Copy link

codecov bot commented Sep 23, 2023 •
edited
Loading

Codecov Report

Merging #51 (6a1d3fb) into main (da8e051) will decrease coverage by 1.03%.
The diff coverage is n/a.

❗ Current head 6a1d3fb differs from pull request most recent head 83f7588. Consider uploading reports for the commit 83f7588 to get more accurate results

@@            Coverage Diff             @@
##             main      #51      +/-   ##
==========================================
- Coverage   49.56%   48.53%   -1.03%     
==========================================
  Files          75       74       -1     
  Lines        6596     6540      -56     
==========================================
- Hits         3269     3174      -95     
- Misses       3327     3366      +39
Files Coverage Δ
src/rtnl/route/header.rs 100.00% <ø> (ø)

... and 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@liuxu623
Copy link
Author

@cathay4t Sorry, I forgot run cargo fmt before.

@liuxu623
support NHFLAGS [ onlink | pervasive ]
bb488e4 
like `ip r add default dev eth0 via 169.254.1.1 onlink`
@liuxu623
Copy link
Author

@cathay4t Already run cargo fmt and cargo clippy,PTAL

@cathay4t cathay4t added Wait_Review and removed Wait_Submitter PR reviewed with change requests labels Oct 8, 2023
@cathay4t
Copy link
Member

cathay4t commented Nov 27, 2023 •
edited
Loading

@liuxu623 Sorry for the delay. I am currently refactoring this crate for the preparation of stable API 1.0 release. Your patch has been inclued in #64

You may check this patch 6393f49 which is for ONLINK.

Sorry for long wait and overstep your works. May I close your PR against mine?

@cathay4t cathay4t added Wait_Submitter PR reviewed with change requests and removed Wait_Review labels Nov 27, 2023
@liuxu623
Copy link
Author

liuxu623 commented Nov 27, 2023 •
edited
Loading

@liuxu623 Sorry for the delay. I am currently refactoring this crate for the preparation of stable API 1.0 release. Your patch has been inclued in #64

You may check this patch 6393f49 which is for ONLINK.

Sorry for long wait and overstep your works. May I close your PR against mine?

@cathay4t ok, I'm looking forward for API 1.0 release.

@liuxu623 liuxu623 closed this Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cathay4t cathay4t Awaiting requested review from cathay4t

Assignees
No one assigned
Labels
Wait_Submitter PR reviewed with change requests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

How to create onlink route?
2 participants
@liuxu623 @cathay4t