Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests #14

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix tests #14

wants to merge 2 commits into from

Conversation

anisse
Copy link
Contributor

@anisse anisse commented Oct 12, 2023

cargo test was broken, fix it, and run it in CI to ensure it does not happen again.

netlink-packet-core update changed enums. Update example code to match.
Cargo test verifies that examples builds, which apparently cargo
llvm-cov does not.
@codecov
Copy link

codecov bot commented Oct 12, 2023

Codecov Report

Merging #14 (58b2a17) into main (30366bd) will decrease coverage by 0.07%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main      #14      +/-   ##
==========================================
- Coverage   40.74%   40.67%   -0.07%     
==========================================
  Files          12       11       -1     
  Lines         886      885       -1     
==========================================
- Hits          361      360       -1     
  Misses        525      525              

see 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@anisse
Copy link
Contributor Author

anisse commented Oct 12, 2023

I'm not sure I understand what changed in the coverage here.

Copy link

@kamyuentse kamyuentse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think can be merged.

Copy link

@sakateka sakateka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge! A useful fix, I also came across it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants