-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix tests #14
base: main
Are you sure you want to change the base?
Fix tests #14
Conversation
netlink-packet-core update changed enums. Update example code to match.
Cargo test verifies that examples builds, which apparently cargo llvm-cov does not.
Codecov Report
@@ Coverage Diff @@
## main #14 +/- ##
==========================================
- Coverage 40.74% 40.67% -0.07%
==========================================
Files 12 11 -1
Lines 886 885 -1
==========================================
- Hits 361 360 -1
Misses 525 525 see 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
I'm not sure I understand what changed in the coverage here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think can be merged.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's merge! A useful fix, I also came across it.
cargo test was broken, fix it, and run it in CI to ensure it does not happen again.