Improve cargo 3ds new #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| eprintln!("cargo-3ds requires a nightly rustc version."); | ||
| // If the channel isn't nightly, we can't make use of the required unstable tools. | ||
| // However, `cargo 3ds new` doesn't have these requirements. | ||
| if rustc_version.channel > Channel::Nightly && input.cmd.should_compile() { |
There was a problem hiding this comment.
Seems like a reasonable relax of the requiement 👍
There was a problem hiding this comment.
Indeed, it felt weird needing to pass +nightly before even getting into the project folder.
ian-h-chamberlain
approved these changes
May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the discussion in #51.
With these changes,
cargo 3ds newcan be run without a nightly toolchain. It also puts a dummy file within the newly builtromfsfolder to ensure a proper git commit configuration.Furthermore,
shlexhad some pretty important security updates so I bumped the requirements and the minimum rust nightly used in the CI has been bumped to stay in line withctru-rs(failed builds under 1.73).