Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --help and print usage if no args specified #7

Merged
merged 1 commit into from
Jan 12, 2022

Conversation

ian-h-chamberlain
Copy link
Member

Hi, hope it's okay I decided to try and add this without opening an issue first. Let me know if you'd like to see any changes.

  • Replace panics for invalid args with help message and exit 2
  • Add -h / --help args (exit 0 when these are used)
  • Cleanup minor clippy lints found along the way

@Meziu
Copy link
Member

Meziu commented Jan 12, 2022

This is great, thank you for the collaboration. Still, don't think about cargo-3ds too much, since it needs a rewrite. Mainly about #1 and #2

@Meziu Meziu merged commit 02e6997 into rust3ds:master Jan 12, 2022
@ian-h-chamberlain
Copy link
Member Author

Sounds good, I mainly wanted this as a way to check cargo-3ds installation for use with cargo-make's test_arg. Presumably all this code would get replaced by a proper CLI library or something at some point.

I definitely plan to focus my contribution efforts more on the other crates 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants