Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite README in Markdown #161 #164

Merged
merged 4 commits into from
Dec 23, 2023
Merged

Rewrite README in Markdown #161 #164

merged 4 commits into from
Dec 23, 2023

Conversation

dogweather
Copy link
Contributor

@dogweather dogweather commented Dec 19, 2023 •
edited
Loading

See #161.

I tested this by:

  1. viewing the rst and this new md one side-by-side
  2. checking the generated md source to make sure it's clean

@dogweather dogweather marked this pull request as ready for review December 19, 2023 21:54
@francium
Copy link
Member

Thanks again. Bit short on time at the moment, so may be a day or two before I can get to reviewing this.
There's a small merge conflict if you're able to resolve it, otherwise I'll handle it went I get to the review.

@dogweather
Copy link
Contributor Author

Thanks! I fixed the conflict.

francium
francium approved these changes Dec 23, 2023
View reviewed changes
Copy link
Member

@francium francium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 👍

@francium francium merged commit c776db4 into rustedpy:master Dec 23, 2023
5 checks passed
@dogweather dogweather deleted the convert-readme-to-md branch December 23, 2023 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@francium francium francium approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dogweather @francium