Skip to content
This repository has been archived by the owner on Jun 24, 2024. It is now read-only.

Basic Integration Testing #337

Merged
merged 15 commits into from
Jul 2, 2023
Merged

Basic Integration Testing #337

merged 15 commits into from
Jul 2, 2023

Conversation

LLukas22
Copy link
Contributor

Starting point for #319

Tests can be run via cargo run --release --bin llm-test and they are integrated into CI. Tests for a specific architecture can be run by defining the architecture in the cli call e.g. cargo run --release --bin llm-test llama. If the models needed for testing can't be found on your system they will be downloaded from huggingface.

Currently they only test if a model is loadable and can generate some tokens. The actual output is not validated.

@LLukas22 LLukas22 marked this pull request as ready for review June 30, 2023 14:41
@LLukas22 LLukas22 requested a review from philpax June 30, 2023 14:42
@philpax
Copy link
Collaborator

philpax commented Jul 1, 2023

Cursory look through looks good, I'll pull it down, test it, and get it merged later today or tomorrow 💪

@philpax
Copy link
Collaborator

philpax commented Jul 1, 2023

I've updated the PR with some clean-up commits, I'll write up the tests later today (will probably put some test cases in the configs) and then this should be good to go

@philpax
Copy link
Collaborator

philpax commented Jul 2, 2023

Alrighty, this should be good to go. @LLukas22 can you check over my changes? This should let us add more tests as required.

@LLukas22
Copy link
Contributor Author

LLukas22 commented Jul 2, 2023

Looks good, but shouldn't the "can send" test be test case?

@philpax
Copy link
Collaborator

philpax commented Jul 2, 2023

I thought about that, but I figured that it didn't make sense to make a one-line check an entirely separate type of test case. I'll think about it and see if there's anything better we can do 🤔

Thanks for getting this started and checking over my changes! I'm super glad that we now have integration tests, especially with all of the architectures! Awesome work 💪

@philpax philpax merged commit 6d24106 into rustformers:main Jul 2, 2023
9 checks passed
@LLukas22 LLukas22 deleted the feat/integration-testing branch July 26, 2023 08:56
@hhamud hhamud mentioned this pull request Aug 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants