This repository has been archived by the owner on Jun 24, 2024. It is now read-only.
Rust 1.72 fixes #416
Merged
Rust 1.72 fixes #416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was trying to work on #412, but ended up side-tracked by this. The most problematic thing is the
Arcnon-Send/Synclint; I went back and forth on this, but I was able to mostly convince myself that our current use is OK because we offer abstractions with different sync guarantees.Still not 100% convinced though, I feel like our GGML bindings need a rethink to better fit Rust safety guarantees 😅